Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors on Status report #34

Open
TravisCarden opened this issue May 5, 2024 · 2 comments
Open

Fix errors on Status report #34

TravisCarden opened this issue May 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@TravisCarden
Copy link
Collaborator

TravisCarden commented May 5, 2024

There are a number of errors and warnings on the Status report on a fresh installation. We should fix as many as we can.

@TravisCarden TravisCarden added the bug Something isn't working label May 5, 2024
@phenaproxima
Copy link
Owner

phenaproxima commented May 6, 2024

  1. The entity/field definitions being out of date is a definite bug and we need to fix that. I'm guessing we might be missing some configuration in our recipes.
  2. The trusted host settings are probably something we should be setting up for local development, like automatically supplying a settings.local.php with trusted_host_patterns including 127.0.01 and localhost (along with the Lando and MAMP versions mentioned in the d.o documentation). We also probably want to update our CI to ensure that we have a trusted host pattern set up for Tugboat.
  3. The Webform problem requires us to solve the "how do you get JavaScript libraries into a Drupal site?" question, which is a long-standing pain point. We might want to consult @lauriii for ideas there; one possibility is to take advantage of npm and supply the libraries in a package.json instead of using hacks like Asset Packagist.

@TravisCarden
Copy link
Collaborator Author

TravisCarden commented May 10, 2024

  • Fixed trusted_host_patterns error on Tugboat: cdb478a.
  • Fixed rebuild access enabled error on Tugboat: 5414fa9...c180240.
  • Turns out Webform module provides a Drush command to install the external libraries. Fixed in 48a22a0. (Note: That takes care of the final error on Tugboat.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants