Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse godot-cpp build actions #167

Open
Ughuuu opened this issue Feb 23, 2024 · 2 comments
Open

Reuse godot-cpp build actions #167

Ughuuu opened this issue Feb 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Ughuuu
Copy link

Ughuuu commented Feb 23, 2024

I have been recently reusing this action/workflow(hope to merge it at some point in godot-cpp-template if possible):

https://github.com/Ughuuu/godot-cpp-template/blob/add-more-stuff/options-to-build/.github/workflows/builds.yml

The basic idea is to build everything and sign for macos using a reusable action

Here is it in action(I ended up creating a file per build type, but aside for that it reuses build from that repo):

https://github.com/V-Sekai/godot-whisper/blob/main/.github/workflows/build_linux.yml

@Ughuuu Ughuuu added the enhancement New feature or request label Feb 23, 2024
@2shady4u
Copy link
Owner

2shady4u commented Mar 4, 2024

Hello @Ughuuu,

The "sign" part of this action seems to be quite useful, but I think it is something that is best implemented on the side of godot-cpp.

Regarding the matrix part of the "builds.yml"-file that you linked. I don't see how this matrix is more versatile/better than the dynamic system I have already implemented in this repository?

@Ughuuu
Copy link
Author

Ughuuu commented Mar 4, 2024

Best thing would be you wouldnt have to maintain it, if it goes into godot-cpp repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants