Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust not found even SKIP_SERVER_RUST is set to true when #1056

Closed
2 tasks done
MohammadAliAfsahi opened this issue May 10, 2024 · 3 comments
Closed
2 tasks done

Rust not found even SKIP_SERVER_RUST is set to true when #1056

MohammadAliAfsahi opened this issue May 10, 2024 · 3 comments

Comments

@MohammadAliAfsahi
Copy link
Contributor

  • I am on the latest ActivityWatch version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • Ubuntu
  • v0.12.3b18-1-g469cbba

Describe the bug

When trying to build the project from source, by running make build command, the following error raised:
ERROR: Rust not found, try running with SKIP_SERVER_RUST=true

To Reproduce

Steps to reproduce the behavior, for example:
1. clone the project
2. try building the project from source using the documentation guides
3. set the SKIP_SERVER_RUST to true as an environment variable
4. When running make build the mentioned error is raised

Expected behavior

When SKIP_SERVER_RUST is set to true, even if cargo is not installed, it should build the source code.

Documentation

Screenshot from 2024-05-10 19-13-38

Copy link

Hi there!
As you're new to this repo, please make sure you've used an appropriate issue template and searched for duplicates (it helps us focus on actual development!). We'd also like to suggest that you read our contribution guidelines and our code of conduct.
Thanks a bunch for opening your first issue! 🙏

@MohammadAliAfsahi
Copy link
Contributor Author

Solution:

I could come up with a solution by change the 52~57 from the following:

	@if (which cargo); then \
		echo 'Rust found!'; \
	else \
		echo 'ERROR: Rust not found, try running with SKIP_SERVER_RUST=true'; \
		exit 1; \
	fi

to

	@if [ "$(SKIP_SERVER_RUST)" = "false" ]; then \
		if (which cargo); then \
			echo 'Rust found!'; \
		else \
			echo 'ERROR: Rust not found, try running with SKIP_SERVER_RUST=true'; \
			exit 1; \
		fi \
	fi
``

@ErikBjare
Copy link
Member

Fixed in 04fbfac :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants