Can't start OME with <P2P> configured

[bchah]

Describe the bug
If you have P2P enabled in your server configuration, OME will not start up:

[2023-11-29 22:06:03.913] I [OvenMediaEngine:498] Config | config_manager.cpp:239  | Trying to set logfile in directory... (/log/engine)
[2023-11-29 22:06:03.914] E [OvenMediaEngine:498] OvenMediaEngine | main.cpp:293  | An error occurred while load config: [Config] Unknown item found: Server.P2P in /opt/ovenmediaengine/bin/conf/Server.xml

I haven't tested this feature in a while but it worked well in the past.

[getroot]

This feature hasn't been tested in a very long time. I'll take a look soon. Thank you

[getroot]

I haven't tested it yet, but P2P config was moved here. Could you modify your Server.xml to <Server><Modules><P2P>

OvenMediaEngine/misc/conf_examples/Server.xml

Line 33 in 594c555

<P2P>

[bchah]

Thank you @getroot, that prevents the crashing. I notice that with the feature enabled, the websocket connection is established but no messages are exchanged. The logs show these clues while the P2P negotiation is attempted:

W [SPICE-t10010:7337] ICE | ice_port.cpp:690  | Could not find agent() information. Dropping... [Packet type : DTLS GateType : SEND_INDICATION]
W [DQICETmout:7334] ICE | ice_port.cpp:527  | Agent [Unknow, 0] has expired

Does this give a good clue? I can dive deeper as needed 🤓

[getroot]

I actually have my mind turned off from the p2p traffic distribution feature (experimental feature). First, I'll put reviving the existing p2p functionality on the backlog and look into it when I have time.
Are you planning to apply this to your service?

[bchah]

Thank you @getroot - it is not a high priority, I just discovered it during some routine testing. However it would be an interesting option to enable for users with constrained networks, since it works like magic with not much change to the config.

…

On Nov 30, 2023, at 8:25 PM, Jeheon Han ***@***.***> wrote: I actually have my mind turned off from the p2p traffic distribution feature (experimental feature). First, I'll put reviving the existing p2p functionality on the backlog and look into it when I have time. Are you planning to apply this to your service? — Reply to this email directly, view it on GitHub <#1466 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIAMIQSZ5LJRC27KETQI3YLYHEWYXAVCNFSM6AAAAABAAGAA3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZVGI2TGNRXGQ>. You are receiving this because you authored the thread.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.