Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admission Webhook not called when forcefully closing RTMP client #1570

Open
bartvp1 opened this issue Mar 29, 2024 · 3 comments
Open

Admission Webhook not called when forcefully closing RTMP client #1570

bartvp1 opened this issue Mar 29, 2024 · 3 comments
Labels
investigating Being checked

Comments

@bartvp1
Copy link

bartvp1 commented Mar 29, 2024

Describe the bug
The admission webhook for closing RTMP streams is not called when a it closes unexpectedly

To Reproduce
Steps to reproduce the behavior:

  1. Set up OME with RTMP ingress & admission webhooks
  2. Start a RTMP stream using Larix
  3. Disable the internet connection on the broadcasting device

Expected behavior
The admission webhook should be called with the information of the cancelled RTMP stream

Server

  • OS: Ubuntu
  • OvenMediaEngine Version: 0.16.5
@getroot
Copy link
Sponsor Member

getroot commented Apr 4, 2024

OME may not be aware that the RTMP session has been disconnected. If TCP keepalive is working, OME will notice the tcp connection termination after several tens of seconds. Admission webhooks aren't being called even though the log shows the stream has been deleted?

@getroot getroot added the investigating Being checked label Apr 4, 2024
@bartvp1
Copy link
Author

bartvp1 commented Apr 4, 2024

The logs don't show anything in regard to the disconnected RTMP client.

@bartvp1
Copy link
Author

bartvp1 commented May 31, 2024

Any updates on this issue?

I need this feature because I need to keep track of active streams in a separate, realtime database.
I investigated whether syncing the redis server (origin map store) would fix this issue, but OME keeps sending SET and EXPIRE commands to the Redis server, despite not receiving any new frames. This results in streams still remaining while they are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating Being checked
Projects
None yet
Development

No branches or pull requests

2 participants