Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataPreprocessor doesn't have it's own failure reason #3073

Open
jshier opened this issue Feb 23, 2020 · 0 comments
Open

DataPreprocessor doesn't have it's own failure reason #3073

jshier opened this issue Feb 23, 2020 · 0 comments
Labels

Comments

@jshier
Copy link
Contributor

jshier commented Feb 23, 2020

Alamofire 5 added a DataPreprocessor protocol to enable the easy filtering of Data before processing, mainly to strip various headers in front of JSON. Unfortunately, when the protocol was added, no corresponding ResponseSerializationFailureReason was added, meaning the failure of a DataPreprocessor will be encapsulated in a .customSerializationFailed reason. Luckily, none of the current DataPreprocessors produce errors, so we may never see this issue.

Fixing this will require a major version change due to the addition of an enum case.

@jshier jshier added the bug label Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant