Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Error Logging Support #3360

Open
tuberd opened this issue Nov 10, 2020 · 4 comments
Open

Network Error Logging Support #3360

tuberd opened this issue Nov 10, 2020 · 4 comments

Comments

@tuberd
Copy link

tuberd commented Nov 10, 2020

What did you do?

NEL (network error logging) is not supported in AlamoFire.

What did you expect to happen?

Clients using AlamoFire should be able to submit NEL reports using the Report-To header in HTTP. This means understanding network failures on the device such as TCP timeouts, resets, aborts, TLS certificate failures, DNS failures, and protocol failures.

What happened instead?

Mobile clients that want to use Network Error Logging cannot upload network error reports to targeted endpoints.

Alamofire Environment

Alamofire version: all
Xcode version: all
Swift version: all
Platform(s) running Alamofire: all
macOS version running Xcode: all

Demo Project

As this is a new feature, any project will reproduce the issue.

@jshier
Copy link
Contributor

jshier commented Nov 10, 2020

While it's unlikely we'd actually support the NEL standard (it's complex and seems to be of rather limited utility), an analysis of what would be need for support outside Alamofire itself would be a good idea to guide future development.

@jshier jshier changed the title [FeatureRequest] NEL support in Alamofire Network Error Logging Support in Alamofire Nov 10, 2020
@tuberd
Copy link
Author

tuberd commented Nov 10, 2020

Hey jon, thanks for responding. If someone were to build support for this, would it be something you would be willing to accept upstream?

@jshier
Copy link
Contributor

jshier commented Nov 10, 2020

Probably not. Enabling it as an external library would be our goal.

@tuberd
Copy link
Author

tuberd commented Nov 10, 2020

So as a library that you can load into Alamofire? Makes sense.

@jshier jshier changed the title Network Error Logging Support in Alamofire Network Error Logging Support Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants