Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add website using docsify #8

Merged
merged 3 commits into from
May 20, 2024

Conversation

Bashamega
Copy link
Contributor

@Bashamega Bashamega commented May 11, 2024

closes #7

Hello:)
The website is done :)
image
If you want i can change theme to be dark mode.

@Bashamega
Copy link
Contributor Author

@Anmol-Baranwal

@Anmol-Baranwal Anmol-Baranwal changed the title New Website feat: add website using docsify May 14, 2024
Copy link
Owner

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bashamega
I am sorry, as I was traveling and didn't get the time to review earlier.

Could you please use this to add a toggle button for light/dark mode?

They also provide the CDN and you can read the docs.

I think it would be great addition so that others can toggle the mode as per their preference.

@Bashamega
Copy link
Contributor Author

@Bashamega
I am sorry, as I was traveling and didn't get the time to review earlier.

Could you please use this to add a toggle button for light/dark mode?

They also provide the CDN and you can read the docs.

I think it would be great addition so that others can toggle the mode as per their preference.

Happy vacation

Sure I am going to check it.

@Bashamega
Copy link
Contributor Author

Done @Anmol-Baranwal

@Anmol-Baranwal
Copy link
Owner

Thank you!
I will merge this by tomorrow.

Copy link
Owner

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

Thanks for contributing, @Bashamega. It looks so much better.

@Anmol-Baranwal Anmol-Baranwal merged commit 7f61f47 into Anmol-Baranwal:main May 20, 2024
@Anmol-Baranwal Anmol-Baranwal added the enhancement New feature or request label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website
2 participants