Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten Posts: Button intersects search box/dropdown #1400

Open
marcustyphoon opened this issue Feb 20, 2024 · 1 comment
Open

Shorten Posts: Button intersects search box/dropdown #1400

marcustyphoon opened this issue Feb 20, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@marcustyphoon
Copy link
Collaborator

Platform

MacOS 13.2.1 arm64

Browser

Chrome 121.0.6167.139, Safari 17.2.1

Addon version

0.23.3

Details

Screenshot 2024-02-19 at 7 46 50 PM
Screenshot 2024-02-19 at 7 47 09 PM

Because the z-index property of both the shorten posts expand button/tags and the search box that floats over search result pages is 2, they intersect unexpectedly.

Should be fixable with isolation: isolate; on the article.

@marcustyphoon marcustyphoon added bug Something isn't working help wanted Extra attention is needed labels Feb 20, 2024
@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Mar 29, 2024

Should be fixable with isolation: isolate; on the article.

This has the slight potential to do bad things. XKit's popup elements—the ones from Quick Reblog and Quick Tags—will appear broken if they're inside an element with this applied. It's not usually possible to click control buttons on shortened posts, though, since the expand button covers the post controls, so you generally have to go out of your way to experience this in practice (e.g. by vertically resizing the browser window), and clicking expand fixes it.

Tumblr's code, as far as I know, uses popper.js and glass container and whatnot rather than actually z-indexing a real child element of a post to make a popup, so this shouldn't cause any issues, but it's not impossible that that could happen in the future.

Or, you know, redpop could use a z-index that differs by more than 1. That's also an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant