-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
break: strictly check operator overload ambiguity #2762
base: main
Are you sure you want to change the base?
break: strictly check operator overload ambiguity #2762
Conversation
bf4335c
to
64425ab
Compare
Perhaps |
Maybe |
|
ping @dcodeIO @CountBleck |
@CountBleck @dcodeIO Could I land it now? |
I can't say all that much about the contents of the PR. @dcodeIO knows what's best. To upgrade the minor version, you need the |
33e0a0a
to
03511df
Compare
03511df
to
67765fa
Compare
friendly ping @dcodeIO |
Could this become a warning that mentions which overload has been picked by the compiler? Similar to my prior comment:
Or do you think that there are good reasons to make it an error and hence a breaking change? |
I think we should forbidden this behavior because:
|
Given that operator overloads are merely an internal mechanism, primarily for string implementation, and not recommended to be used for anything custom anyway as these won't typecheck, I guess it's fine to check these strictly and error otherwise. More generally, I'd probably even prefer that we limit their use, and encouraged the use of |
Agree. |
fixes: #2761