Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Notifications should not be disabled by default #1100

Open
june1025 opened this issue May 15, 2024 · 5 comments
Open

[FEATURE] - Notifications should not be disabled by default #1100

june1025 opened this issue May 15, 2024 · 5 comments
Labels
enhancement New feature or request planned To be done in future.

Comments

@june1025
Copy link

What is your feature request regarding to?

Atlas Playbook

Is your feature request related to a problem? Please describe.

Currently, by default, Atlas completely disables notifications. I think that this is an unintuitive default, and that something as important as notifications should be untouched, and left up to the user to configure.

Describe the solution you would like.

Keep notifications enabled by default

Describe alternatives you have considered.

n/a

Additional context.

No response

@june1025 june1025 added the enhancement New feature or request label May 15, 2024
@trolljoe
Copy link

doesn't it ask you if you wanna disable it or not in the playbook?

@june1025
Copy link
Author

Yeah i guess i missed that. I still think it should be opt-in in the installer though, not enabled by default.

@Ast3risk-ops
Copy link

Ast3risk-ops commented May 15, 2024

What are you even saying, it is opt-in. (https://github.com/Atlas-OS/Atlas/blob/main/src/playbook/playbook.conf#L111-L116)

@june1025
Copy link
Author

First of all, "What are you even saying" is not the nicest way to respond to someone. Second, let me clarify what I mean: when you go through the Atlas installer, disable notifications is on by default. Of course you can just turn it off, but I think that disabling notifications is quite extreme, and shouldn't be opt-out, as it's quite easy to gloss over, as I just did here.

@he3als he3als added the planned To be done in future. label May 16, 2024
@he3als
Copy link
Member

he3als commented May 16, 2024

What are you even saying, it is opt-in. (https://github.com/Atlas-OS/Atlas/blob/main/src/playbook/playbook.conf#L111-L116)

Please don't be rude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planned To be done in future.
Projects
None yet
Development

No branches or pull requests

4 participants