Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A fade In and fade Out for segments in MultiSegmentPlayer #2749

Open
quantamrhino opened this issue Jul 17, 2022 · 2 comments
Open

A fade In and fade Out for segments in MultiSegmentPlayer #2749

quantamrhino opened this issue Jul 17, 2022 · 2 comments

Comments

@quantamrhino
Copy link

Is your feature request related to a problem? Please describe.
I'm trying to get samples to sound good with the multisegmentplayer (which is amazing bytheway), but they cut out, or cut in too abruptly.

Describe the solution you'd like
Perhaps having an optional configurable fade in/fade out per segment will be truly amazing.

Describe alternatives you've considered
Couldn't think of how to do the fades any other way. adding faders for each segment wouldn't trigger in time correctly.

@Matt54
Copy link
Member

Matt54 commented Jul 19, 2022

I may take a stab at this at some point... I have seen this implemented with timers before, but there may be more appropriate way of handling this.

I imagine we would want some optional "Fade In definition" property and "Fade Out definition" property included with SteamableSegment

I can imagine each "fade" definition would need:

  • duration: TimeInterval
  • *curveFunction: (ratioOfCompletion: Float) -> Float
  • minVolume
  • maxVolume
    *perhaps just start with linear interpolation

Then we would then need a method for scheduling the fades. Lot's of options there.

@quantamrhino
Copy link
Author

Oh that'll be superb! Many thanks sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants