Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Privacy Manifest for SDK #2905

Open
dennyaby opened this issue Apr 9, 2024 · 6 comments
Open

No Privacy Manifest for SDK #2905

dennyaby opened this issue Apr 9, 2024 · 6 comments
Labels

Comments

@dennyaby
Copy link

dennyaby commented Apr 9, 2024

macOS Version(s) Used to Build

macOS 13 Ventura

Xcode Version(s)

Xcode 14

Description

Every app and SDK should include privacy manifest if it is using api from the list (apple documentation). This SDK is using mach_absolute_time call which is in the list. Privacy manifest should be added before 1 May 2024 or it will be impossible to upload new versions of the app using this SDK to App Store Connect.

Crash Logs, Screenshots or Other Attachments (if applicable)

No response

@dennyaby dennyaby added the bug label Apr 9, 2024
@NickCulbertson
Copy link
Member

I'm not sure if that should be added to AudioKit or just mentioned in the documentation.

@marcussatellite
Copy link
Contributor

marcussatellite commented Apr 9, 2024 via email

@megastep
Copy link
Member

megastep commented Apr 9, 2024

Ideally it should be included in the framework, these manifests are merged with the one from the client apps when submitting to the App Store and this is simple enough to do. It's just a plist.

@marcussatellite
Copy link
Contributor

marcussatellite commented Apr 9, 2024 via email

@mahal
Copy link
Contributor

mahal commented Apr 10, 2024

Following manifest solved the warnings from Xcode cloud and Appstore Connect for my app:

https://gist.github.com/mahal/3357789345e1a47bd8bee3c0f66e2557

  • Reason 8FFB.1 as AudioKit uses mach_absolute_time to calculate absolute timestamps for audio.
  • Reason C617.1 as STKAudioKit uses stat() to determine file lenght while reading from disk.

Don't know how to add this to the framework and PR though... Maybe it helps.

@dennyaby
Copy link
Author

Privacy Manifest should be included in the SDK, per apple docs:

You need to include a privacy manifest file in your third-party SDK if it’s listed in “SDKs that require a privacy manifest and signature,” in Upcoming third-party SDK requirements. Otherwise, include a privacy manifest file in your third-party SDK if it uses required reasons API, collects data about the person using apps that include the third-party SDK, enables the app to collect data about people using the app, or contacts tracking domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants