Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question Answer Tool changes #767

Merged
merged 64 commits into from Apr 30, 2024
Merged

Question Answer Tool changes #767

merged 64 commits into from Apr 30, 2024

Conversation

komalg1
Copy link
Collaborator

@komalg1 komalg1 commented Apr 29, 2024 •
edited

Purpose

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
The Web chat application should be able to return results along with citations for the ingested documents.

@komalg1
downloading the contents of url & uploading blob
b53c1b0
@komalg1
changes for downloading url content & uploading to blob
b706206
@komalg1
Merge branch 'main' into komal/iv-addurl-pull
39d373b
@komalg1
Adding url as the metadata to the blob
636bfcf
@komalg1
PR only for adding environment var
4404b89
@komalg1
removing chnages unrelated to env variable
71bab88
@komalg1
Grouping integrated vec. with azure search
b54c002
@komalg1
upadting description to match the usage
7edbf1e
@komalg1
grouping search variables
73cd9c0
@komalg1
Spike for resource creation
4b84909
@komalg1
Merge branch 'main' into komal/pull-resources-creation
a96be78
@komalg1
Failing build due to poetry lock file
92c5923
@komalg1
Merge branch 'main' into komal/pull-resources-creation
1879966
@komalg1
pull resources creation
f1baf8c
@komalg1
Pull resource creation refactoring
4cb2a16
@komalg1
Merge branch 'main' into komal/pull-resources-creation
fd76585
@komalg1
updating index field names
f5f4190
@komalg1
fixing tests for when using IV
c82910a
@komalg1
changes for rbac IV
b370b77
@komalg1
role for storage & tests
49ef655
@komalg1
unit tests for helpers
8798b64
@komalg1
unit tests for helper classes
0c8a8fa
@komalg1
Merge branch 'main' into komal/pull-resources-creation
44bd0be
@komalg1
code review changes
05e1663
@komalg1
Merge branch 'main' into komal/pull-resources-creation
7e5e103
@komalg1
tests update
811eaeb
@komalg1
Explore Data changes
6cf0868
@komalg1
Merge branch 'main' into komal/iv-explorepage
b18a1af
@komalg1
decoupled explore & delete pages
16d11c3
@komalg1
Merge branch 'main' into komal/iv-explorepage
e949a85
@komalg1 komalg1 requested a review from adamdougal April 29, 2024 15:10
@ross-p-smith
Copy link
Collaborator

Thank you for persisting with this - I love how the QuestionAnswerTool is slimmer now!! 💖 I can approve when the tests pass

@superhindupur
Copy link
Collaborator

LGTM too. Will wait for you to fix the unit tests, and I can approve. Thanks Komal!

@ross-p-smith ross-p-smith mentioned this pull request Apr 30, 2024
Closed
@komalg1 komalg1 added this pull request to the merge queue Apr 30, 2024
Merged via the queue into Azure-Samples:main with commit ca911bf Apr 30, 2024
5 checks passed
@komalg1 komalg1 deleted the komal/iv-questionanswer branch April 30, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecheta cecheta cecheta left review comments

@superhindupur superhindupur superhindupur approved these changes

@ross-p-smith ross-p-smith ross-p-smith approved these changes

@adamdougal adamdougal Awaiting requested review from adamdougal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating QuestionAnswerTool to use Pull index & perform similarity search (remove get_vector_store())
5 participants
@komalg1 @ross-p-smith @superhindupur @adamdougal @cecheta