Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated: trim() with PHP 8.2 #138

Open
yovannygomez opened this issue Jun 5, 2023 · 3 comments
Open

Deprecated: trim() with PHP 8.2 #138

yovannygomez opened this issue Jun 5, 2023 · 3 comments

Comments

@yovannygomez
Copy link

yovannygomez commented Jun 5, 2023 •
edited

I have updated my project to PHP 8.2 and the warning has started to appear. My brainmaestro/composer-git-hooks version of is v2.8.5

Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /vendor/brainmaestro/composer-git-hooks/src/helpers.php on line 54
@yovannygomez yovannygomez changed the title Deprecated: trim( Deprecated: trim() with PHP 8.2 Jun 5, 2023
@ZejdCicak
Copy link
Contributor

ZejdCicak commented Jun 19, 2023 •
edited

I have fixed this and it has been merged to master but it was not tagged yet, I have no idea why.

You can check it here: #137

@leymannx
Copy link

leymannx commented Oct 6, 2023

@BrainMaestro – Can we get this tagged please. 🙏🏻 🙂

@yovannygomez
Copy link
Author

@ZejdCicak you're right. I already saw your merged. The commit id was 3d197c4. But I don't know how we can generate a new tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leymannx @ZejdCicak @yovannygomez