-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation is so painful #20
Comments
I'll not argue as your point is totally valid, and is something to be worked on the future, but reason on what led to this Python PackagingPython tooling for multiple local dependent packages is terrible, I'm fighting against this for at least 2 years. The simplest solution, and that works the best so far, was to just bundle everything on a single wheel and It's too useful having a main library for common behavior. Rust does this VERY well defining a main Poetry needed some over-engineered code to manage the multiple venvs per project and was very error prone. Rye solved 90% of the immediate problems, namely a single venv for all projects, managing a specific Python version and bundling VersioningI really wanted to have multiple separate packages for isolation and I don't have to worry about this if the PyPI wheel contains always the "current of everything", and submodules are always up-to-date. That's why it's the most effective one currently Logistics issues of this form will become less common, as lib/projects settle on a stable naming and behavior Users and Python InstallationFor that, I chose to manage the submodule hell on development side. Nevertheless, "from source" mode is automated with a single script under https://brokensrc.dev/get/source, and I'll be uploading new wheels soon.. ..but then, if I recommend pip install, it requires Python, which users might not add to PATH, or not have pip (hi Linux Mint), or 3.12/3.13 requires compilers for some packages, etc. It's painful to instruct on every errors possibility Closing ThoughtsAlso, DepthFlow is really a ShaderFlow spin-off, which focus partly on audio reactiveness. It's a tech demo / full application of the bigger project. I hope this clarifies it. Python really is simultaneously the best and worst programming language 😓 |
I did not mean to come across as critical -- I'm was/am very excited to use this, but I've spent half of yesterday and half of today fighting to get it running. I thought pip install would be easiest, but was running into issues with cmake and samplerate (none of which are your fault). Then I was fighting pip to fix that before giving up and building from source. Building from source was a lot nicer than I expected, but I had issues with symlink and xvfb since it isn't installed on my machine and I don't have admin rights (neither are your fault, but most AI based projects tend to be headless linux first). As I said -- most of it isn't your fault, but I think the traction this has is substantially bigger than ShaderFlow and in my mind (although I understand that you are the one with the vision of what you want this to evolve into), deserves to work as a standalone project. Maybe it helps to clarify my use-case. I want to add simple animation to static images to make them more eye catching. This does a perfect job of being unique and eyecatching. Now I can build programmatically build a video slideshow from a bunch of images and make them be a lot more interesting than standard transitions. Hell, if there was an API for this so I didn't need to host it myself, I would pay for that (hence my recommendation for you to stick this on Replicate 😉) |
My man. This seems like a fantastic project and I've been trying to get it running for the last 2 days.
It's been a constant roadblock of errors everywhere. Admittedly, not all of it comes down to your package (I'm on a headless server without admin rights), but some of the installation process is quite ridiculous.
Why do I need to install broken-source & every package you've created? Why are there sound libraries in a project which doesn't need sound? Why does installation take over 30mins?
I feel this could be as simple as "git clone depthflow" and then "depthflow --image X", with only the dependencies that are required for this project.
Or, stick your model on huggingface spaces/replicate. I know you may have a lot on your plate but the exposure you'd get by doing this might encourage some open source contributors to help out.
This is the first model of its kind on github (that I could find) -- make getting started with it easy and you'll be the main repo for this stuff
The text was updated successfully, but these errors were encountered: