Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use samplings for the knots in b-splines #416

Closed
EmilyBourne opened this issue Apr 18, 2024 · 3 comments
Closed

Use samplings for the knots in b-splines #416

EmilyBourne opened this issue Apr 18, 2024 · 3 comments
Assignees

Comments

@EmilyBourne
Copy link
Collaborator

Now that #121 has been merged it is possible to have multiple samplings on the same dimension. This should be used to define the knots of splines. This will avoid the use of uid()

@EmilyBourne EmilyBourne self-assigned this Apr 18, 2024
@tpadioleau
Copy link
Member

I think we already use it ? Do you mean to use it outside the the [Non]UniformBSplines classes ? For now it is not exposed in the public API but could be.

@EmilyBourne
Copy link
Collaborator Author

Having looked at the code in more detail I think you are right. The knots are saved into a sampling, however the sampling I think it is possible to write the code in a way that uses this more explicitly to give more DDC-like code. I will propose a PR once #415 is merged

@tpadioleau
Copy link
Member

Superseded by #432 and #459.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants