Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check assignement operators for DiscreteElement/DiscreteVector/DiscreteDomain/TaggedVector #424

Closed
2 tasks
tpadioleau opened this issue Apr 22, 2024 · 1 comment · Fixed by #460
Closed
2 tasks

Check assignement operators for DiscreteElement/DiscreteVector/DiscreteDomain/TaggedVector #424

tpadioleau opened this issue Apr 22, 2024 · 1 comment · Fixed by #460
Labels
bug Something isn't working

Comments

@tpadioleau
Copy link
Member

tpadioleau commented Apr 22, 2024 •
edited

Some of them have an incorrect implementation, fortunately they do not seem to compile because they use private member variables of other classes.

  • Fix them
  • Add tests
@tpadioleau tpadioleau added the bug Something isn't working label Apr 22, 2024
@tpadioleau tpadioleau changed the title Check assignement operators for DiscreteElement/DiscreteVector/TaggedVector Check assignement operators for DiscreteElement/DiscreteVector/DiscreteDomain/TaggedVector May 26, 2024
@tpadioleau
Copy link
Member Author

Following the guidelines of https://www.foonathan.net/2017/10/explicit-assignment/, we have decided to have explicit reordering constructors so to be consistent we should remove the reordering assignments.

@tpadioleau tpadioleau linked a pull request May 26, 2024 that will close this issue
Fix inconsistency between explicit constructors and assignement ope… #460
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inconsistency between explicit constructors and assignement ope… CExA-project/ddc
1 participant
@tpadioleau