Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] [Filter Manipulation] Add more filter customization options to let users further differentiate our app's filter changes #253

Open
SirTwsted opened this issue Oct 25, 2021 · 4 comments
Labels
enhancement New feature or request low priority We want to prioritize this class of issue well after others

Comments

@SirTwsted
Copy link

There is a huge problem with this that I noticed, maybe im missing something but.
If you have to colorize the items, wouldnt that confuse the FilterBlade Filters people
have downloaded already?

Maybe this tool should put something like a Diamond Icon. Or even the icon for the
Choas Orb itself on the item banner, so people know its for the Tool,
while also not messing with the FilterBlades Filter settings and colors people have already assigned to their items .....

Just a thought 👋🤡👍

@HiMarioLopez HiMarioLopez added enhancement New feature or request question Further information is requested by the user (generally should refer to resource and close ASAP) labels Feb 3, 2022
@mikedorsi
Copy link

mikedorsi commented Feb 8, 2022

This would be a huge enhancement to the tool. I second this opinion. I've personally already created my own loot filter around the chaos recipe. The main difference is PoeEnhance can tell me if I need the item or not by directly putting an icon next to the text name or only changing the border color or background color for example.

@Davst
Copy link

Davst commented Feb 23, 2022

The real MVP move here would be if Filterblade would somehow allow you to tag a section and that the tool could show/hide that section. This has been accomplised before with some start and end tagging in the filters.. which tbh is a mess sinnce you have to edit it after downloading.

Not sure if you could speak to Neversink and somehow have something like this added as a custom feature selectable in Neversink.. that way the config should persist between updates with the tool just switching that on and off.

Until then, the current method is pretty good since it does infact override the normal logic of the filter which I appriciate as I can run on Very strict and still get items.

Having more selections for the look and feel of the items wouldn't hurt.. like sound, iconn Text, frame, bg and fg. Would be cool with a few preset looks as well.

@Davst
Copy link

Davst commented Feb 23, 2022

Btw could we renname this to something more descriptive of the discussion?

@HiMarioLopez HiMarioLopez changed the title Some concerns about this tool. [Enhancement] [Filter Manipulation] Add more filter customization options to let users further differentiate our app's filter changes May 17, 2022
@HiMarioLopez HiMarioLopez added low priority We want to prioritize this class of issue well after others and removed question Further information is requested by the user (generally should refer to resource and close ASAP) labels May 17, 2022
@HiMarioLopez
Copy link
Collaborator

HiMarioLopez commented May 17, 2022

Would be a neat thing to add.

Filter syntax: https://www.pathofexile.com/item-filter/about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority We want to prioritize this class of issue well after others
Projects
None yet
Development

No branches or pull requests

4 participants