Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] [Genera] Additional Safeguards for Reduced Chance of Rate Limiting (e.g. Limits for Stash Tab Selections, Set Threshold) #510

Open
n1ob opened this issue Oct 4, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@n1ob
Copy link

n1ob commented Oct 4, 2023

Hi,

Windows 11, 2560 x 1600, scale 150%, core i9

  1. adding to many tabs did hit the api transaction limit, got notified, but also got an exception. Maybe you need to slow down the fetching.
  2. It took me some time to find how to move the grid. Maybe you should change the cursor to signal when it´s possible to move the thing.
  3. It is very hard to to find the right spot for to enable edit mode in the overlay. I still don´t understand the systematic.
@n1ob n1ob changed the title API limit hit, not able to vertically align overlay, not able to hit edit with minified overlay API limit hit, not able to vertically align overlay, not able to hit edit with overlay Oct 4, 2023
@HiMarioLopez HiMarioLopez added the needs splitting Multiple issues lumped into one; we need to split this up. label Dec 2, 2023
@HiMarioLopez
Copy link
Collaborator

HiMarioLopez commented Dec 2, 2023

I will be wanting to add a few limits to:

  • Full Set Threshold (i.e. Number of sets to gather)
  • Tab Selections
    • Aside from some pretty dicey challenges that will come with some dynamic implicit rate limiting done on our part, it also causes some very unfortunate visual bugs once you break the number of tabs you have past 5 or so.

How many tabs did you attempt to add when it bugged out for you?

As for your 2nd 3rd issue, I have seen this reported a few times and will be sure to continue to be on the look out. If you have any reproduction steps for it, that would be of much use. Thanks

@HiMarioLopez
Copy link
Collaborator

I missed your 2nd point. I will take a look at the visuals for the resizer. It's been pointed out a few times, that's a great suggestion. Thank you

@HiMarioLopez HiMarioLopez changed the title API limit hit, not able to vertically align overlay, not able to hit edit with overlay [Enhancement] [Genera] Additional Safeguards for Reduced Chance of Rate Limiting (e.g. Limits for Stash Tab Selections, Set Threshold) Dec 2, 2023
@HiMarioLopez HiMarioLopez added enhancement New feature or request and removed needs splitting Multiple issues lumped into one; we need to split this up. labels Dec 2, 2023
@HiMarioLopez
Copy link
Collaborator

I have added a new minimum for set thresholds at 1, and a new maximum of 100. Ref: 2159a96#diff-8a044bc5c209622b18ad5c883031f120999f53f09b2d5f3f43af9a5ca1a4c97b

I will keep this issue open as I still want to take a look at the stash selection rate limiting that happens from time to time. This is a rare case, but it does exist. I will, however, move this to a lower priority.

@HiMarioLopez HiMarioLopez reopened this Dec 3, 2023
@HiMarioLopez HiMarioLopez added the low priority We want to prioritize this class of issue well after others label Dec 3, 2023
@HiMarioLopez HiMarioLopez removed the low priority We want to prioritize this class of issue well after others label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants