Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Bottom can not kill service/tasksch started processes #1241

Open
1 task done
JABirchall opened this issue Jul 4, 2023 · 1 comment
Open
1 task done

[Windows] Bottom can not kill service/tasksch started processes #1241

JABirchall opened this issue Jul 4, 2023 · 1 comment
Labels
bug Something isn't working the way that is expected.

Comments

@JABirchall
Copy link

JABirchall commented Jul 4, 2023

Checklist

What operating system and version are you using?

Windows 10 22H2 19045.3086

What architecture are you using?

x86_64 / AMD64

What terminal(s) are you running bottom on?

Running from NuShell in Windows Terminal - With admin privilages

What version of bottom are you running?

0.9.3

How did you install bottom?

winget

Describe the issue

When running bottom with admin permissions, bottom can not kill processes started by a service or scheduled task.
These tasks can be killed forcefully under admin permissions using taskkill /F /PID

WindowsTerminal

Many software make them selfs PUPs by adding perisistance into the system, such as scheduled tasks or installing a service.
Which the user wants to kill.

What is the expected behaviour?

Attempt/provide other methods to kill a process.

Such as, if the terminateprocess fails, attempt to use taskkill /F /PID {Process_ID}

What is the actual behaviour?

The kill process fails.

How can we reproduce this?

Run a process as a service. Example used in GIF is anydesk, likes to install its self as a persistant service once used.

Attempt to kill that process running as a service child process.

Observe permission failure.

Additional information

@JABirchall JABirchall added the bug Something isn't working the way that is expected. label Jul 4, 2023
@ClementTsang
Copy link
Owner

ClementTsang commented Jul 4, 2023

Noted, will try to reproduce and fix. The way I do process killing in Windows is a bit jank so I wouldn't be surprised if it's not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way that is expected.
Projects
None yet
Development

No branches or pull requests

2 participants