Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Improvements to SwiftLint #1673

Open
armartinez opened this issue Apr 17, 2024 · 2 comments
Open

🧹 Improvements to SwiftLint #1673

armartinez opened this issue Apr 17, 2024 · 2 comments
Assignees
Labels

Comments

@armartinez
Copy link
Contributor

armartinez commented Apr 17, 2024

Description

Expand the reach of SwifLint to include:

  • Ordering of properties in classes and structs.
  • Minimum line size
@armartinez armartinez added the enhancement New feature or request label Apr 17, 2024
@activcoding activcoding self-assigned this Apr 17, 2024
@austincondiff austincondiff added chore and removed enhancement New feature or request triage needed labels Apr 17, 2024
@austincondiff austincondiff changed the title ✨ Improvements to SwiftLint 🧹 Improvements to SwiftLint Apr 17, 2024
@activcoding
Copy link
Member

I looked into SwiftLint and found out it doesn't have rules for ordering properties or setting a minimum line length. This is understandable as it's challenging for SwiftLint to determine whether a line break is intended for improved readability or if it's unnecessary. Here's what I think we should do:

  1. Update the Code Style Guide docs
  2. Follow Community Standards: Use common coding standards as a guide.
  3. Use common sense

However, I would like to suggest that we could enable force_unwrapping and implicit_return. What do you think?

@0xWDG
Copy link
Collaborator

0xWDG commented Apr 20, 2024

I'm not really a fan of implicit_return, IMHO it makes it more difficult for starters to know when or when not to use a return.

However we should definitely discourage the use of force unwrapping so force_unwrapping should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

No branches or pull requests

5 participants
@austincondiff @0xWDG @armartinez @activcoding and others