Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recaf ignoring classes. #742

Closed
RareHyperIonYT opened this issue Nov 21, 2023 · 2 comments
Closed

Recaf ignoring classes. #742

RareHyperIonYT opened this issue Nov 21, 2023 · 2 comments
Labels
2.X 3rd party problem A bug/problem but caused by a library 3.X

Comments

@RareHyperIonYT
Copy link

Describe the bug

Recaf does not process any of the obfuscated classes when I provide a obfuscated jar, it is only showing assets such as json, png, and yml.
When I try to open the jar with a ZipInputStream in java it says it is encrypted, the file is not encrypted, it can be accessed via WinRar.
The classes are obfuscated with ".class/" at the end of each class which tricks WinRar into thinking they are folders.
The fix I used is to patch the zip file by replacing ".class/" with ".class" and setting each ZipEntry compression level to -1 to open the jar with recaf.

To Reproduce

Steps to reproduce the behavior:

  1. Open sample.jar using Recaf.

Console Output

19:12:45.065 [ForkJoinPool-1-worker-1] INFO : Loaded workspace from: sample.jar
19:12:45.065 [ForkJoinPool-1-worker-2] DEBUG: Begin generating phantom classes, given 0 input classes
19:12:45.066 [ForkJoinPool-1-worker-1] INFO : Detected 0 illegal names
19:12:45.148 [ForkJoinPool-1-worker-2] DEBUG: Phantom analysis complete, generated 0 classes
19:12:45.149 [ForkJoinPool-1-worker-2] DEBUG: Generated 0 phantom classes in 83 ms

Screenshots
recaf
winrar

@Col-E
Copy link
Owner

Col-E commented Nov 22, 2023

Recaf 2X/3X use older versions of the ZIP parser library we made to handle such cases. The updated parser supports these cases. I've not backported its use from 4X down to 3X.

image

@Col-E Col-E added 3rd party problem A bug/problem but caused by a library 3.X 2.X labels Nov 22, 2023
@Col-E
Copy link
Owner

Col-E commented May 19, 2024

Closing as 4.X is the only branch we're working on going forward, and it addresses the issue.

@Col-E Col-E closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.X 3rd party problem A bug/problem but caused by a library 3.X
Projects
None yet
Development

No branches or pull requests

2 participants