Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SODA integration #783

Open
skrawcz opened this issue Mar 26, 2024 · 0 comments
Open

Add SODA integration #783

skrawcz opened this issue Mar 26, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request i/o product idea

Comments

@skrawcz
Copy link
Collaborator

skrawcz commented Mar 26, 2024

Is your feature request related to a problem? Please describe.
Enable checks with SODA - e.g. https://docs.soda.io/soda/connect-dask.html.

Describe the solution you'd like

I think a UX in Hamilton could look like:

@tag(scan_definition_name="test", 
 data_set_name="employee", 
 data_source_name="orders")
def some_dataset() -> pd.DataFrame:
 # pandas/spark/dask logic
 return df

# then when you execute you provide the soda adapter that will trigger after executing `some_dataset()` in memory.
soda_adapter = Soda(checks_yaml, ...)
dr = driver.Builder()...with_adapters(soda_adapter).build()
dr.execute(["some_dataset"], inputs=...)

Describe alternatives you've considered
Could go about extending @check_output or @check_output_custom like we've done with pandera.

Additional context
SODA is a contract library.

@skrawcz skrawcz added documentation Improvements or additions to documentation enhancement New feature or request product idea i/o labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request i/o product idea
Projects
None yet
Development

No branches or pull requests

1 participant