Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] GraphFeatureExtractor #1723

Open
2 tasks done
EloyAnguiano opened this issue Oct 23, 2023 · 2 comments
Open
2 tasks done

[Feature Request] GraphFeatureExtractor #1723

EloyAnguiano opened this issue Oct 23, 2023 · 2 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@EloyAnguiano
Copy link

馃殌 Feature

Graph feature extractor for the new observation space that gymnassium provides.

Motivation

I've been using a Graph2Vec aproximation using GraphTransformers and CLS tokens on a non-publishable custom environment. As Gymnassium has implemented the Graph observation space, I would like to code a Feature Extractor for that kind of observation spaces.

Pitch

I want agents to use graph as observations

Alternatives

The alternative is to create a custom feature extractor that handles a dictionary space of the matrixes and attributes of graphs, but when the graph is very big this is not very optimal. The final goal would be to work with batches of graphs and sparse tensors.

Additional context

The only remaining piece is an official or publicly available gym environment to test this Feature Extractor. Does anyone know about this?

Checklist

  • I have checked that there is no similar issue in the repo
  • If I'm requesting a new feature, I have proposed alternatives
@EloyAnguiano EloyAnguiano added the enhancement New feature or request label Oct 23, 2023
@araffin
Copy link
Member

araffin commented Oct 23, 2023

Probably a duplicate of #1280

@araffin araffin added the duplicate This issue or pull request already exists label Oct 23, 2023
@EloyAnguiano EloyAnguiano changed the title [Feature Request] GraphFeatureExtracor [Feature Request] GraphFeatureExtractor Oct 24, 2023
@EloyAnguiano
Copy link
Author

I think that one thing is that the whole SB3 framework can handle graphs (batches of graphs, rollout buffers of graphs, etc...) and another thing would be making a Feature Extractor once that happens. Would it be ver媒 difficult to adapt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants