Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyndicationFeed still contains references to JSPUI and XMLUI #9572

Closed
saschaszott opened this issue May 13, 2024 · 2 comments · Fixed by #9576
Closed

SyndicationFeed still contains references to JSPUI and XMLUI #9572

saschaszott opened this issue May 13, 2024 · 2 comments · Fixed by #9576
Assignees
Labels
bug code task Code cleanup task integration: syndication feed Related to RSS / ATOM syndication feeds
Milestone

Comments

@saschaszott
Copy link
Contributor

Bug Description

In org.dspace.app.util.SyndicationFeed some references to JSPUI and XMLUI are still present.

Furthermore, OpenSearchController has a reference to SyndicationFeed.UITYPE_JSPUI in

labelMap.put(SyndicationFeed.MSG_UITYPE, SyndicationFeed.UITYPE_JSPUI);

@tdonohue , I can try to fix this problem but I'm not sure if MSG_UITYPE is completely obsolete in DS 7 and can be safely removed from SyndicationFeed? I can confirm that old (DS5) RSS feed URLs do not contain any reference to the UI mode.

@saschaszott saschaszott added bug needs triage New issue needs triage and/or scheduling labels May 13, 2024
@tdonohue
Copy link
Member

@saschaszott : Yes, it appears to me that MSG_UITYPE may be no longer necessary and likely should be entirely removed.

@tdonohue tdonohue added integration: syndication feed Related to RSS / ATOM syndication feeds code task Code cleanup task and removed needs triage New issue needs triage and/or scheduling labels May 13, 2024
@tdonohue
Copy link
Member

Claiming this as I had time to look into it. It's a quick fix & necessary to patch soon. The RSS/Atom feeds are returning invalid URLs for bitstreams (e.g. community/collection logos). I'll create the PR today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code task Code cleanup task integration: syndication feed Related to RSS / ATOM syndication feeds
Projects
Development

Successfully merging a pull request may close this issue.

2 participants