Remove old UI references from OpenSearch / RSS feeds #9576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
bug
1 APPROVAL
…s. Also enable/fix a test for special characters.
tdonohue
force-pushed
the
remove_old_ui_refs
branch
from
a77029a
to
8c22915
Compare
tdonohue
commented
May 29, 2024
There was a problem hiding this comment.
Merging as this is minor code cleanup that is all covered by Integration Tests. Primarily it's just removing references to XMLUI/JSPUI. The only functional change is to ensure OpenSearch uses new Bitstream URLs instead of older XMLUI-based URLs....and this functional change has ITs to prove it works
|
Successfully created backport PR for |
tdonohue
removed
the
port to dspace-7_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Removes UI-type related functionality from OpenSearch & RSS feeds. It was still being used to generate Bitstream URLs (for community/collection logos) but these URLs were incorrect for DSpace 7+.
This code fixes the Bitstream URL to be of the format:
[dspace.ui.url]/bitstreams/[uuid]/downloadIt also adds a basic IT to verify these logo URLs are correct now.
In fixing this bug, I found a disabled test which uses OpenSearch for special characters. I added a minor fix to get it to work, and enabled it.