Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioner and CWL-on-ARM integration tests fail on master because no tests are run #4935

Closed
adamnovak opened this issue May 16, 2024 · 3 comments
Assignees

Comments

@adamnovak
Copy link
Member

adamnovak commented May 16, 2024

In https://ucsc-ci.com/databiosphere/toil/-/jobs/67645 and https://ucsc-ci.com/databiosphere/toil/-/jobs/67642, for the last run of scheduled tests that managed to get past the build stage, neither integration test job ran any tests, and so the jobs failed.

This is why #4918, which we want for the upcoming release, is failing tests. Its CWL on ARM test run also is not running any tests.

We need to figure out why these tests are all getting skipped and fix it.

┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1571

@adamnovak adamnovak changed the title Provisioner and CWL-on-ARM integration tests fail on master bwcause no tests are run Provisioner and CWL-on-ARM integration tests fail on master because no tests are run May 16, 2024
@adamnovak
Copy link
Member Author

It looks like the CWL on ARM test is failing because the CWL on ARM test was cut in #4892, but the logic to require it in Gitlab for periodic tests or for PRs that touch CWL stuff was not removed.

@adamnovak
Copy link
Member Author

The provisioner tests are failing because src/toil/test/wdl/wdltoil_test.py::WDLKubernetesClusterTest is included in the list of tests to run, but that class does not exist. Having the nonexistent class in the list causes all the tests to fail to be loaded for some reason, without producing an error about a missing class.

This problem was introduced in #4859 when the class was moved to toil/src/toil/test/wdl/wdltoil_test_kubernetes.py instead, but CI did not notice that the change affected the provisioner integration test job and did not run it for the PR.

@unito-bot
Copy link

➤ Adam Novak commented:

Actually the ARM test just moved, to src/toil/test/provisioners/clusterTest.py

@DailyDreaming DailyDreaming mentioned this issue May 17, 2024
19 tasks
@stxue1 stxue1 closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants