Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Query tags not being set in insert_by_period materialisation #195

Open
NiallRees opened this issue May 27, 2023 · 3 comments
Open
Assignees
Labels
bug Something isn't working feature This is is requesting a new feature

Comments

@NiallRees
Copy link

NiallRees commented May 27, 2023

It looks as though query tags aren't being set anywhere in the insert_by_period materialization (haven't checked others). In the dbt-snowflake adapter, these are set here: https://github.com/dbt-labs/dbt-snowflake/blob/main/dbt/include/snowflake/macros/materializations/incremental.sql#L61

AB#5360

@NiallRees NiallRees added the feature This is is requesting a new feature label May 27, 2023
@DVAlexHiggs
Copy link
Member

DVAlexHiggs commented May 27, 2023

Hello. Thanks for this report!

I believe this is layover from the fact we based our custom materialisations on a now quite old and defunct version of the core dbt incremental materialisation (which didn't originally do anything with tags) and they are due a much-needed refresh.

We shall add it to the backlog!

@NiallRees
Copy link
Author

Cheers @DVAlexHiggs! Hope you're keeping well

@NiallRees
Copy link
Author

For more context, our package uses some query tag metadata.

@DVAlexHiggs DVAlexHiggs added the bug Something isn't working label May 15, 2024
@DVAlexHiggs DVAlexHiggs changed the title Query tags not being set in insert_by_period materialisation [BUG] Query tags not being set in insert_by_period materialisation May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature This is is requesting a new feature
Projects
None yet
Development

No branches or pull requests

2 participants