Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] MS Fabric support #226

Open
jx1226 opened this issue Feb 2, 2024 · 3 comments
Open

[FEATURE] MS Fabric support #226

jx1226 opened this issue Feb 2, 2024 · 3 comments
Assignees
Labels
feature This is is requesting a new feature

Comments

@jx1226
Copy link

jx1226 commented Feb 2, 2024

Hello greetings,

I would like to evaluate dbtvault in MS Fabric environment. I was wondering if you already have a some idea of what is necessary to get dbtvault to run on MS Fabric or maybe already started working on this.

Depending on the effort, glad be able to help reach the support of Ms Fabric.

Best regards

AB#5347

@jx1226 jx1226 added the feature This is is requesting a new feature label Feb 2, 2024
@rudolf-sauer-mw
Copy link

One idea could be to simply copy the dispatch logic from "sqlserver" and call it "fabric" and your good to go.

Here is one example "type_timestamp.sql"

{%- macro type_timestamp() -%}
{{- return(adapter.dispatch('type_timestamp', 'automate_dv')()) -}}
{%- endmacro -%}

{%- macro default__type_timestamp() -%}
TIMESTAMP_NTZ
{%- endmacro -%}

{%- macro sqlserver__type_timestamp() -%}
DATETIME2
{%- endmacro -%}

{%- macro fabric__type_timestamp() -%}
DATETIME2
{%- endmacro -%}

If you use this approach everything works fine - except the dbt model versions ( https://docs.getdbt.com/reference/resource-properties/versions )

@mattiasthalen
Copy link

mattiasthalen commented Apr 5, 2024

This is what I'm doing

One idea could be to simply copy the dispatch logic from "sqlserver" and call it "fabric" and your good to go.

Here is one example "type_timestamp.sql"

{%- macro type_timestamp() -%} {{- return(adapter.dispatch('type_timestamp', 'automate_dv')()) -}} {%- endmacro -%}

{%- macro default__type_timestamp() -%} TIMESTAMP_NTZ {%- endmacro -%}

{%- macro sqlserver__type_timestamp() -%} DATETIME2 {%- endmacro -%}

{%- macro fabric__type_timestamp() -%} DATETIME2 {%- endmacro -%}

If you use this approach everything works fine - except the dbt model versions ( https://docs.getdbt.com/reference/resource-properties/versions )

That's how I do it

Edit:
I went ahead and made a pull request: Add Fabric Support

@DVAlexHiggs
Copy link
Member

Thank you for this request and sorry for the delayed response. MS Fabric and AWS Redshift are next on the roadmap for support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This is is requesting a new feature
Projects
None yet
Development

No branches or pull requests

4 participants