Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decimal seperator issue in currency calculator #16

Open
tfp opened this issue Mar 7, 2020 · 4 comments
Open

decimal seperator issue in currency calculator #16

tfp opened this issue Mar 7, 2020 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@tfp
Copy link

tfp commented Mar 7, 2020

In the poe.ninja window if you want to calculate fractions of currency conversions e.g. between Exalts and Chaos, there is only '.' allowed as decimal seperator instead the local one. But in my region (germany) is ',' the decimal seperator.
What happens is, that I can't type in '0,5' only '0.5'. But '0.5' is then parsed with localisation with the (somewhat correct) result '5'.
That means it's currently not possible on german windows to calculate fractions of currencies.
(Just to note: all displays of fractions are correct)
image

@DeadlyCrush DeadlyCrush self-assigned this Mar 7, 2020
@DeadlyCrush DeadlyCrush added the good first issue Good for newcomers label Mar 7, 2020
@DeadlyCrush
Copy link
Owner

Ah. Thank you for your report. I will check decimal separator by Region and share the progress here.

@DeadlyCrush
Copy link
Owner

1st Update 1.4.0.1
Rework (Trade Notification, ChatScan, Settings, UI) + a few new useful features. + bug fix. + stablized.
→ 2020.03.10~2020.03.11 (local time in Korea)

2nd Update 1.4.0.2
Add price check related main features like trademacro and currenycop.
→ 2020.03.13~2020.03.14 (local time in Korea)

@DeadlyCrush
Copy link
Owner

=======================
1.4.0.3 DeadlyTrade Released.

○ CONFIG File is changed.

  • Sorry, CONFIG File is changed for BUG Fix.

○ BUG FIX

  • Fixed Labyrinth Overlay Zoomin, Zoomout, Close Button Action
  • Fixed Moving stash tab by CTRL+MouseWheel
  • Fixed Trade Notification Pop-up
  • Fixed Korean Trade Message Parsing
    . Korean trade whisper changed that cause trade message parsing bug.
    . Korean trade whisper's a few default words was changed. ex) 을(를) to (을)를
  • Fixed Cache File Cleaner : ShaderCacheD3D11 & ShaderCacheD3D11_GI
  • Fixed Save Configuration in Settings.

@DeadlyCrush
Copy link
Owner

Sorry for late. Stabilizing was done at 1.4.0.4 version. And some bug fixed at 1.4.0.5 version.

So, I will add/modify your region character problem next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants