[@types/selectize] Add types for missing methods #69378
Conversation
|
@codershiba Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PRCode ReviewsThis PR can be merged once it's reviewed. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69378,
"author": "codershiba",
"headCommitOid": "634d3a78c6549a98c63fa88bbeadd40bf6da8fa2",
"mergeBaseOid": "895d2be48edd77037fb8920161d109059d600002",
"lastPushDate": "2024-04-17T10:44:15.000Z",
"lastActivityDate": "2024-05-28T20:29:45.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/events.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "selectize",
"kind": "edit",
"files": [
{
"path": "types/selectize/index.d.ts",
"kind": "definition"
}
],
"owners": [
"adidahiya",
"naBausch"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "changereq",
"reviewer": "sheetalkamat",
"date": "2024-05-28T20:29:45.000Z"
}
],
"mainBotCommentID": 2060967891,
"ciResult": "pass"
} |
typescript-bot
added
Popular package
|
Hey @codershiba, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky @adidahiya @naBausch — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in New Pull Request Status Board
|
@codershiba The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in New Pull Request Status Board
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in New Pull Request Status Board
|
Re-ping @adidahiya, @naBausch: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
typescript-bot
added
the
Unreviewed
iisaduan
moved this from Needs Maintainer Review
to Waiting for Code Reviews
in New Pull Request Status Board
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Action
in New Pull Request Status Board
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @codershiba. (Ping @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky, @adidahiya, @naBausch.) |
|
As in the other PR, DT is at 0.12, and this package upstream is at 0.15; can you verify which versions things were added? |
typescript-bot
added
Critical package
Edits multiple packages
and removed
Popular package
typescript-bot
added
the
Revision needed
typescript-bot
removed
the
Unreviewed
typescript-bot
moved this from Needs Maintainer Action
to Needs Author Action
in New Pull Request Status Board
|
@codershiba One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Closes #69336
Closes #69377
Please fill in this template.
pnpm test selectize.If changing an existing definition:
package.json.