Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat hydromet_stratified.py Following PEP8 #47

Open
ShaneMPutnam opened this issue Jun 16, 2020 · 1 comment
Open

Reformat hydromet_stratified.py Following PEP8 #47

ShaneMPutnam opened this issue Jun 16, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@ShaneMPutnam
Copy link
Member

All local variables and functions should be lower case and for readability, all functions should have a description even if they seem self-explanatory.
@ShaneMPutnam ShaneMPutnam added the enhancement New feature or request label Jun 16, 2020
@ShaneMPutnam
Copy link
Member Author

Also, use descriptive variable names when possible. Instead of calling a variable "R" use "rainfall_total" and then add the units and additional information to the docstring.

@ShaneMPutnam ShaneMPutnam mentioned this issue Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShaneMPutnam