Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: PushSubscription.id should be a String #2050

Open
1 task done
dcwatson opened this issue May 2, 2024 · 3 comments
Open
1 task done

Bug: PushSubscription.id should be a String #2050

dcwatson opened this issue May 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@dcwatson
Copy link

dcwatson commented May 2, 2024

Description

According to https://docs.joinmastodon.org/entities/WebPushSubscription/#id the PushSubscription ID is cast from an int, but should be a string. I'm implementing a server, and sending back an integer as a string causes IceCubes to not be able to set subscription options.

Related Issues

  • Search that this bugs don't already exist before creating it.
@dcwatson dcwatson added the bug Something isn't working label May 2, 2024
@Dimillian
Copy link
Owner

Interesting, I'm not doing any custom decoding, so I guess it's just a bug in the Mastodon API and they won't change it since it would break many clients.

@dcwatson
Copy link
Author

dcwatson commented May 2, 2024

It's hard to tell what are bugs and what is just outdated documentation sometimes 😁 I'm going to change my server to send integers anyway, so do with this what you will!

@Dimillian
Copy link
Owner

Nice! I know it was causing some issues to some other Fediverse servers too, but this is a Mastodon client hehe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants