Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Login issues with [REDACTED] #2058

Open
distantcam opened this issue May 6, 2024 · 1 comment
Open

Bug: Login issues with [REDACTED] #2058

distantcam opened this issue May 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@distantcam
Copy link

Ok, bear with me on this.

I've been developing my own maston api compatible server, and I was having issues with login with icecubes.

I eventually found the issue, and fixed it on my server side, and I'm wondering if the same issue is presenting login issues from other implementations.

For me, the issue was case insensitivity of the Visibility flag in the timeline call after login. My server was returning Public but IceCubes wasn't recognizing that.

In https://github.com/Dimillian/IceCubesApp/blob/main/Packages/Models/Sources/Models/Status.swift this code

public enum Visibility: String, Codable, CaseIterable, Hashable, Equatable, Sendable {
  case pub = "public"
  case unlisted
  case priv = "private"
  case direct
}

I suspect overriding pub with a string like that breaks the case insensitivity of CaseIterable (I'm not a swift dev)

Anyway, hopefully this can help with some of the other login bugs like #1661 and #2038

@distantcam distantcam added the bug Something isn't working label May 6, 2024
@Dimillian
Copy link
Owner

I need to check; I thought all the JSON decoding was done in case insensitive. I can set it up if it's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants