Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Tabs collapsible 模式下，通过修改 activeKey 切换 tab 时不会将选中的 tab 出来 #2239

Closed
1 task done
l123wx opened this issue May 15, 2024 · 1 comment · Fixed by #2241
Closed
1 task done

[BUG] Tabs collapsible 模式下，通过修改 activeKey 切换 tab 时不会将选中的 tab 出来 #2239

l123wx opened this issue May 15, 2024 · 1 comment · Fixed by #2241

Comments

@l123wx
Copy link
Contributor

l123wx commented May 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Which Component

Tabs

Semi Version

No response

Current Behavior

Tabs collapsible 模式下，直接点击弹出的选项会将选中的 tab scroll into view，通过修改 activeKey 切换不会将选中的 tab 展示出来

2024-05-15.15-08-37.mp4

Expected Behavior

通过 activeKey 切换选中 tab 也会展示出来

Steps To Reproduce

No response

ReproducibleCode

No response

Environment

- OS: windows 10
- browser: edge 124.0.2478.67 (正式版本) (64 位)

Anything else?

No response
@l123wx l123wx changed the title [BUG] <Tabs collapsible 模式下，通过修改 activeKey 切换 tab 时不会将选中的 tab 出来> [BUG] Tabs collapsible 模式下，通过修改 activeKey 切换 tab 时不会将选中的 tab 出来 May 15, 2024
@l123wx
Copy link
Contributor Author

l123wx commented May 15, 2024

有一个 相同的 issue #1367，解决方案是 切换 activeKey 之后调用 scrollIntoView 将 tab 展示出来

这里我不明白的是为什么点击的时候可以展示出来，而修改 activeKey 的时候需要额外调用 选中 tab 的 scrollIntoView...

l123wx added a commit to l123wx/semi-design that referenced this issue May 16, 2024
@l123wx
fix(tabs): Fixed the issue where the overflow tab did not scroll into…
63a080b 
… view when the activeKey changed(DouyinFE#2239)
@l123wx l123wx mentioned this issue May 16, 2024
Merged
15 tasks
YannLynn pushed a commit that referenced this issue May 20, 2024
@l123wx
fix(tabs): Fixed the issue where the overflow tab did not scroll into…
08c76a5 
… view when the activeKey changed(#2239) (#2241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tabs): Fixed the issue where the overflow tab did not scroll into… l123wx/semi-design
1 participant
@l123wx