Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opcode_mix initializers #6812

Open
edeiana opened this issue May 15, 2024 · 0 comments
Open

Update opcode_mix initializers #6812

edeiana opened this issue May 15, 2024 · 0 comments

Comments

@edeiana
Copy link
Contributor

edeiana commented May 15, 2024

analysis_tool_tmpl_t deprecated the use of initialize() and parallel_shard_init() in favor of initialize_stream() and parallel_shard_init_stream() respectively.
These two methods allow initializations for the analysis tool as a whole (rather than doing them in the constructor) and for a trace shard (for parallel analysis tools).
The new methods add an additional memtrace_stream_t parameter, which enables tools to query details of the underlying trace (e.g., the file type of the trace).

Currently opcode_mix still uses the deprecated initializers. We want to update it to use the new initializers.

edeiana added a commit that referenced this issue May 16, 2024
Fixes a data race due to multiple dr_standalone_init() done in parallel
(per shard) by encodings2regdeps_filter_t.
dcontext is now initialized one time by record_filter_t and passed to
its filters through the record_filter_info_t interface.

Avoids a data race in opcode_mix where all threads set the dcontext
isa_mode to DR_ISA_REGDEPS for regdeps input traces.

Issue #6662 #6812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant