Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] Remove -no_intercept_all_signals #5261

Open
derekbruening opened this issue Dec 20, 2021 · 0 comments · May be fixed by #6818
Open

[cleanup] Remove -no_intercept_all_signals #5261

derekbruening opened this issue Dec 20, 2021 · 0 comments · May be fixed by #6818
Labels
Maintainability OpSys-UNIX Type-Feature

Comments

@derekbruening
Copy link
Contributor

Dropping support for -no_intercept_all_signals and removing the option would simplify some of the signal-handling code. I do not think we'll ever go back to not intercepting all signals. Xref #2311 where we may want to reduce emulation for the signal mask, but I don't think we'd want to or be able to reduce emulation of signal handling/delivery.
@derekbruening derekbruening mentioned this issue Dec 20, 2021
Merged
xdje42 added a commit that referenced this issue May 17, 2024
@xdje42
i#5261 remove --intercept_all_signals: Remove option
a5b481d 
--intercept_all_signals is the default. We always want to intercept all
signals. --no_intercept_all_signals requires extra code to support, and
the support is problematic, eg, is racy.
Since we don't use --no_intercept_all_signals any more, remove the option.

Fixes #5261
@xdje42 xdje42 linked a pull request May 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintainability OpSys-UNIX Type-Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#5261 remove -intercept_all_signals: Remove option DynamoRIO/dynamorio
1 participant
@derekbruening