Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrustAllX509TrustManager android lint warning SSLBlindTrustManager #206

Open
antoni-sgz-tw opened this issue Sep 13, 2022 · 3 comments
Open

Comments

@antoni-sgz-tw
Copy link

antoni-sgz-tw commented Sep 13, 2022

Environment

  • Android Studio Chipmunk | 2021.2.1 Patch 2
  • openkit-java v2.2.0

Problem
warning [TrustAllX509TrustManager](https://github.com/Dynatrace/openkit-java/issues/new#TrustAllX509TrustManager): Insecure TLS/SSL trust manager

Insecure TLS/SSL trust manager [../../com/dynatrace/openkit/protocol/ssl/SSLBlindTrustManager%24BlindX509TrustManager.class](https://github.com/Dynatrace/com/dynatrace/openkit/protocol/ssl/SSLBlindTrustManager%24BlindX509TrustManager.class): checkClientTrusted is empty, which could cause insecure network traffic due to trusting arbitrary TLS/SSL certificates presented by peers [../../com/dynatrace/openkit/protocol/ssl/SSLBlindTrustManager%24BlindX509TrustManager.class](https://github.com/Dynatrace/com/dynatrace/openkit/protocol/ssl/SSLBlindTrustManager%24BlindX509TrustManager.class): checkServerTrusted is empty, which could cause insecure network traffic due to trusting arbitrary TLS/SSL certificates presented by peers

Steps to reproduce

  • Run lintDebug Gradle task
    ./gradlew lintDebug
@antoni-sgz-tw antoni-sgz-tw changed the title TrustAllX509TrustManager lint warning SSLBlindTrustManager TrustAllX509TrustManager android lint warning SSLBlindTrustManager Sep 13, 2022
@TheHighriser
Copy link
Contributor

The SSLBlindTrustManager only exists for debugging purpose. We know that this Manager is insecure, but its main purpose is to exclude certificate problems (if there are any). Per default this manager is not in use.

Do you expect us to ignore those lint warnings?

@antoni-sgz-tw
Copy link
Author

antoni-sgz-tw commented Sep 14, 2022

If possible yes.

To work around provisionally I ignored the warning in the lint.xml file
<?xml version="1.0" encoding="UTF-8"?> <lint> <issue id="TrustAllX509TrustManager" severity="ignore"> <ignore path="*/com/dynatrace" /> </issue> </lint>

@TheHighriser
Copy link
Contributor

TheHighriser commented Sep 23, 2022

We will try to take care of it with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants