Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compressed image will not be set as watermark #38

Open
vin-zhou opened this issue Jan 16, 2018 · 2 comments
Open

Compressed image will not be set as watermark #38

vin-zhou opened this issue Jan 16, 2018 · 2 comments
Labels
enhancement example

Comments

@vin-zhou
Copy link

The judgement of isGIF in GeneratorController.swift Line 1079 will defend using the compressed image returned from selectedAlbumPhotosIncludingGifWithPHAssets, which seems a bug.
@EyreFree
Copy link
Member

EyreFree commented Feb 1, 2018

Only type 'kUTTypeGIF' image will make 'isGIF' true, in GeneratorController.swift Line 1079.

@ApolloZhu
Copy link
Member

Might be relevant https://developer.apple.com/documentation/photokit/phimagerequestoptions/1616934-networkaccessallowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement example
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vin-zhou @EyreFree @ApolloZhu