Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Refactor map clusters to use tailwind instead of css modules #10155

Open
1 task done
ChinmayMhatre opened this issue Jan 20, 2024 · 15 comments
Open
1 task done
Labels
⭐ goal: addition undefined 🔢 points: 5 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@ChinmayMhatre
Copy link
Member

Is this a unique feature?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.

https://github.com/EddieHubCommunity/BioDrop/tree/main/components/map

Cluster.js uses css modules for styles.

Proposed Solution

We can refactor it to use tailwind classes for consistency?

Screenshots

No response

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

@ChinmayMhatre ChinmayMhatre added ⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Jan 20, 2024
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
@amandamartin-dev
Copy link
Contributor

great idea!

@amandamartin-dev amandamartin-dev added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Feb 3, 2024
@github-actions github-actions bot unlocked this conversation Feb 3, 2024
Copy link
Contributor

github-actions bot commented Feb 3, 2024

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@eddiejaoude eddiejaoude added the 🔢 points: 5 undefined label Feb 4, 2024
@Apurv428
Copy link

Hi @amandamartin-dev , can I work on this issue?

@SaraJaoude
Copy link
Member

Hi amandamartin-dev , can I work on this issue?

@Apurv428 thank you for your enthusiasm to work on this project. Please avoid tagging a specific maintainer, as this creates unnecessary extra notifications. All maintainers receive notifications and can assign an Issue.

I can see that you have not yet contributed to this project. We ask new contributors to start off with issues between 1-3 Points (this is 5 points).

@Apurv428
Copy link

Sure, how can I identify a problem within a range of 1 to 3 points? Also, sorry for tagging!

@ChinmayMhatre
Copy link
Member Author

Sure, how can I identify a problem within a range of 1 to 3 points? Also, sorry for tagging!

The Issues ready for dev have a label called "Point: [number of points]" in the issues tab
image

@Apurv428
Copy link

All issues identified with points 1, 2, and 3 have been allocated to a contributor for resolution.

@SaraJaoude
Copy link
Member

All issues identified with points 1, 2, and 3 have been allocated to a contributor for resolution.

@Apurv428 I suggest every once in a while you take a look at the unallocated issues as we regularly have new ones coming up. Please come and chat to us about these types of topics on the EddieHub Discord, rather than in the comments to a specific Issue - as it is best to leave the comments here dedicated to the Issue.

@Apurv428
Copy link

Thank you for your suggestion, and I apologize for not being aware of the existence of a Discord community. I will be more cautious moving forward.

@dhruvilmehta
Copy link
Member

So in Cluster.js, wherever we are using styles, we have to use tailwind components? Basically, we have to get rid of the Clusters.module.css?

@ChinmayMhatre
Copy link
Member Author

So in Cluster.js, wherever we are using styles, we have to use tailwind components? Basically, we have to get rid of the Clusters.module.css?

Yep

@bikrantjajware
Copy link
Contributor

Hello, can i work on this. I have some experience in tailwind and i've contributed to biodrop before

@SaraJaoude
Copy link
Member

Hello, can i work on this. I have some experience in tailwind and i've contributed to biodrop before

@bikrantjajware thank you for your enthusiasm, but we do ask contributors to have worked on a few Issues between 1-3 Points (beyond creating their BioDrop profile) before assigning Issues with 5 Points, like in this case.

@irungudennisnganga
Copy link

hello, can i be assigned to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ goal: addition undefined 🔢 points: 5 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

No branches or pull requests

8 participants