Fixes the issue realted to adding/ updating events tags not been saved and making form unsubmissive #10221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… form unsubmissive - Made description field required
ThomasCode92
reviewed
Feb 5, 2024
luismr00
reviewed
Feb 22, 2024
There was a problem hiding this comment.
I tested the new change and everything works. However, the button does not get disabled anymore whenever you are missing a field. This probably does not matter because even if you hit the save button, it will throw an alert if you are missing a field. I would ask another maintainer if they are ok with this, or if they still want the button to become disabled whenever input fields are missing.
|
Can I get an update on this PR? if it is still having an issue then please do let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #10197
Changes proposed
Descriptionfield was made required as per theEventschemasetIsDisabled(true)in thehandleSubmit()function as this was making the form disabled after inputting the tags.Check List (Check all the applicable boxes)
Screenshots
Creating a new Event
Updating Event
Note to reviewers
I have added and updated some sample events locally to test the application flow and it was working fine.