Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add Hover Effect for Explaining Uneditable Links #10215

Open
1 task done
ThomasCode92 opened this issue Feb 2, 2024 · 14 comments
Open
1 task done

[BUG] Add Hover Effect for Explaining Uneditable Links #10215

ThomasCode92 opened this issue Feb 2, 2024 · 14 comments
Assignees
Labels
🛠 goal: fix undefined 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@ThomasCode92
Copy link
Member

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

Production

Version of BioDrop (for example "v1.2.3")

v2.99.12

Description

When users attempt to edit a link of their profile, there is no feedback or explanation provided for why the link cannot be edited. This lack of information can lead to confusion, especially for new users.

Proposed Solution
Implement a hover effect on uneditable links that triggers a tooltip or a small pop-up, providing a clear explanation for why the link cannot be edited. This enhancement will improve user experience and help users understand the constraints on link editing.

Steps to Reproduce

  1. Go to your profile page.
  2. In the center, click Edit in Links tab
  3. Click the edit button of any link.
  4. Try editting the url of the link

Screenshots

image

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

@ThomasCode92 ThomasCode92 added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
@amandamartin-dev
Copy link
Contributor

amandamartin-dev commented Feb 3, 2024

@ThomasCode92 great idea, what would be the mobile experience?

ℹ️ amandamartin-dev has some opened assigned issues: 🔧View assigned issues

@EddieHubCommunity EddieHubCommunity unlocked this conversation Feb 3, 2024
@ThomasCode92
Copy link
Member Author

ThomasCode92 commented Feb 3, 2024

Maybe we can show some sort of helper text below (or above) the input?

ℹ️ ThomasCode92 has some opened assigned issues: 🔧View assigned issues

@amandamartin-dev
Copy link
Contributor

Maybe we can show some sort of helper text below (or above) the input?

That could be a good solution for both experiences perhaps? Will add the discussion tag so others can weigh in on the best way to approach too. Thank you for your thoughts.

@manassingh17
Copy link

May be we can use lock icons to visually indicate that it is not editable

@Rick-ftw
Copy link

I guess tooltip will work better for new users.

@SohamRoy-01
Copy link
Member

SohamRoy-01 commented Mar 24, 2024

Can I work on this issue @ThomasCode92 @amandamartin-dev ,
My approach is pretty simple add a title attribute in the input field will do the work

@ThomasCode92
Copy link
Member Author

@SohamRoy-01, you'll need to direct your inquiry to one of the maintainers. As for me, feel free to proceed with your work, but I lack the authority to make decisions as I'm not a maintainer.

@SohamRoy-01
Copy link
Member

Ok @ThomasCode92.
Can I work on this issue @eddiejaoude ?

@BamaCharanChhandogi
Copy link

hello @ThomasCode92,
I am saying the link should be editable because users can enter a wrong link, so they may want to try to fix it.

@eddiejaoude
Copy link
Member

@BamaCharanChhandogi I am saying the link should be editable because users can enter a wrong link, so they may want to try to fix it.

This will confusion with the stats, that is why we make it uneditable - they can create a new link in their profile

@SohamRoy-01 My approach is pretty simple add a title attribute in the input field will do the work

Simple is good, we can make it fancier if required later on

@SohamRoy-01 I will assign it to you, thanks

@eddiejaoude eddiejaoude added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 💬 talk: discussion undefined labels Apr 22, 2024
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@eddiejaoude eddiejaoude added the 🔢 points: 2 undefined label Apr 22, 2024
@BamaCharanChhandogi
Copy link

hey, @eddiejaoude I am also available if @SohamRoy-01 doesn't want to work.

@SohamRoy-01
Copy link
Member

SohamRoy-01 commented Apr 22, 2024

Thanks for assigning @eddiejaoude I will work on it .

ℹ️ SohamRoy-01 has some opened assigned issues: 🔧View assigned issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 goal: fix undefined 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

No branches or pull requests

7 participants