Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add 404 page to all pages in a users account/* path #10292

Open
1 task done
MaorBemdoo opened this issue Mar 18, 2024 · 4 comments
Open
1 task done

[FEATURE] Add 404 page to all pages in a users account/* path #10292

MaorBemdoo opened this issue Mar 18, 2024 · 4 comments
Labels
⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)

Comments

@MaorBemdoo
Copy link
Contributor

Is this a unique feature?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.

If a user already has a json file, you are adviced on the forms to continue using your json file while if you use the forms and you try to make a pr for your json file, the gh workflow for accounts fails, telling you you are already on the biodrop database so continue using forms. I have tried both so this is from experience

Proposed Solution

I suggest instead of telling a user to keep using their json file on their forms page(and yet they still edit on their forms page), all routes in account/ should redirect to a 404 page or say somthing like delete your json file first

Screenshots

No response

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

@MaorBemdoo MaorBemdoo added ⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Mar 18, 2024
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@amandamartin-dev
Copy link
Contributor

I am not sure I am following and I think a 404 page would be very confusing to folks.

When I go to edit my profile in forms, there is a notification letting me know that I have a json file still and I should delete it. Do you not see this?
delete-json-message

@EddieHubCommunity EddieHubCommunity unlocked this conversation Apr 27, 2024
@MaorBemdoo
Copy link
Contributor Author

I understand, my suggestion was that instead of advicing a user to delete their json data all routes to edit their profile on forms should redirect to a page telling them to keep using their json file(i.e they should not be able to edit on the forms)

@amandamartin-dev
Copy link
Contributor

I understand, my suggestion was that instead of advicing a user to delete their json data all routes to edit their profile on forms should redirect to a page telling them to keep using their json file(i.e they should not be able to edit on the forms)

Users are allowed and encouraged to use forms regardless of if they started with the json profile. We would not want to discourage this, but if you think there is a way to make it more clear that you should use one or the other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)
Projects
None yet
Development

No branches or pull requests

2 participants