Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Change the hover color of the light/dark mode and github icon #10305

Open
1 task done
Abiheb opened this issue Mar 23, 2024 · 8 comments · May be fixed by #10355
Open
1 task done

[FEATURE] Change the hover color of the light/dark mode and github icon #10305

Abiheb opened this issue Mar 23, 2024 · 8 comments · May be fixed by #10355
Assignees
Labels
⭐ goal: addition undefined 🔢 points: 1 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@Abiheb
Copy link

Abiheb commented Mar 23, 2024

Is this a unique feature?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.

Currently, there is inconsistency in the color scheme within the navbar of the application. When hovering over elements such as "Search," "Events," "Repos," "Pricing," "Login," and "Sign up," the color scheme follows a red/pink theme. However, when toggling between light/dark mode and hovering over the GitHub icon, the color abruptly changes to blue. This inconsistency detracts from the overall visual coherence and user experience of the application.

Proposed Solution

The proposed enhancement aims to maintain consistency in the color scheme throughout the navbar. By unifying the color scheme to red/pink for all elements, including during hover states and across different modes (light/dark), the visual aesthetic of the navbar will be improved, providing users with a more cohesive and seamless experience.

Screenshots

github feature 2 github feature

Do you want to work on this issue?

Yes

If "yes" to above, please explain how you would technically implement this

To technically implement this enhancement, the CSS styles responsible for defining the colors of the navbar elements during hover states and across different modes would need to be adjusted, this could involve modifying existing CSS classes. Additionally, any JavaScript functions associated with toggling between light/dark mode or handling hover effects may need to be updated to reflect the unified color scheme.

@Abiheb Abiheb added ⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Mar 23, 2024
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
@amandamartin-dev amandamartin-dev added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 1 undefined and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Apr 27, 2024
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot unlocked this conversation Apr 27, 2024
@Vijaykv5
Copy link
Member

I would love to work on it @amandamartin-dev

@amandamartin-dev
Copy link
Contributor

I would love to work on it @amandamartin-dev

you are assigned!

@Abiheb
Copy link
Author

Abiheb commented Apr 27, 2024

Doesn't the person who create the issue have priority for working on it, because when writing the issue it asks you wether you want to work on it or no and I specified "yes" @amandamartin-dev, also I have already began working working on it and should be done within 2 days

@amandamartin-dev
Copy link
Contributor

Doesn't the person who create the issue have priority for working on it, because when writing the issue it asks you wether you want to work on it or no and I specified "yes" @amandamartin-dev, also I have already began working working on it and should be done within 2 days

Oh my. Apologies you are correct. Will fix the assignment. However, I would net recommend in the future working on an issue before it is unlocked in case it is modified or not approved for work.

@Vijaykv5 I am removing your assignment. I placed you in error. Please take a look through other issues

@amandamartin-dev amandamartin-dev assigned Abiheb and unassigned Vijaykv5 Apr 27, 2024
@Abiheb
Copy link
Author

Abiheb commented Apr 27, 2024

Ok thank you

ℹ️ Abiheb has some opened assigned issues: 🔧View assigned issues

Abiheb added a commit to Abiheb/BioDrop that referenced this issue Apr 28, 2024
@Abiheb Abiheb linked a pull request Apr 28, 2024 that will close this issue
6 tasks
@anantha0811
Copy link

Hi @amandamartin-dev I would love to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ goal: addition undefined 🔢 points: 1 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
4 participants