Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded tilde input bind #485

Open
locosux opened this issue Apr 27, 2018 · 3 comments
Open

Remove hard-coded tilde input bind #485

locosux opened this issue Apr 27, 2018 · 3 comments

Comments

@locosux
Copy link

locosux commented Apr 27, 2018

if (GetKeyTicks(eKeyCodeTilde, eInputTypeUi) == 1 || GetKeyTicks(eKeyCodeF1, eInputTypeUi) == 1)

A configuration override could be added to disable the usage of tilde (or f1) to open the console.
Also seems a bit silly to have two (unbindable) keys dedicated to opening the console.

It's a common voip push-to-talk hot-key.
It looks like a simple change, I just don't have a dev environment setup to test it out.

@HomerGaidarski
Copy link

yes i definitely want this too, i have a dev environment setup, gonna take longer to add to the keybinding menu a place for setting the console key, so i'm just gonna remove the tilde bind to the console.

@HomerGaidarski
Copy link

unfortunately removing GetKeyTicks(eKeyCodeTilde, eInputTypeUi) == 1 from that line only prevents the console from popping up while you're playing the game, but if you try to set the tilde key in the keyboard edit menu the console still pops up, so this fixes your issue if you primarily use discord client for communication but not for common voice chat in halo

@locosux
Copy link
Author

locosux commented Apr 29, 2018

It looks like the following two lines also handle showing the console:
Title screen:

if(e.keyCode == 192 || e.keyCode == 112 || e.keyCode == 223){

Loading screen:
if(e.which == 192 || e.which == 112){

And for closing:
if(e.keyCode == 192 || e.keyCode == 112 || e.keyCode == 223){

Tilde is keyboard code 192 in javascript.
Side note: any idea what 223 is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants