Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<div> should not be handle by a noop rule #19

Open
EvitanRelta opened this issue Dec 20, 2022 · 0 comments
Open

<div> should not be handle by a noop rule #19

EvitanRelta opened this issue Dec 20, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@EvitanRelta
Copy link
Owner

EvitanRelta commented Dec 20, 2022

Context

Currently, <div> are handled by a noop rule, meaning they aren't stripped but they only pass-on their converted inner-contents to their parents. They themselves don't have any markdown conversions, not even in HTML-syntax.
For example, the below 2 HTML:

<div>
  TEXT
</div>
<div aligned="center">
  TEXT
</div>

both gives the same output of:

TEXT

The problem

<div> in markdowns aren't stripped when being rendered in Github.
For example, they can be used to center images, like:

<div align=center>
  <img src="...">
</div>

Thus, they should not be converted by a noop rule.

@EvitanRelta EvitanRelta added the bug Something isn't working label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant