Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Item#onStackClicked for clearer distinction #3533

Open
Phoupraw opened this issue Apr 1, 2023 · 0 comments
Open

Rename Item#onStackClicked for clearer distinction #3533

Phoupraw opened this issue Apr 1, 2023 · 0 comments
Labels
refactor A PR that renames existing names.

Comments

@Phoupraw
Copy link

Phoupraw commented Apr 1, 2023

Item#onStackClicked is not able to be distinguished clearly from Item#onClicked. Users have to read their doc for clearer distinction (however, their doc seems not enough unclear, either.)

"onStackClicked" sounds to seem to an event that the item stack itself is clicked but not that the item stack clicks another item stack. Especially when comparing with "onClicked", they are more confusing.

So I suggest that the word "click" shouldn't be past participle but should be basic form or third-person singular; the word "on" should be placed behind "click". For example, "clickOnOther".

@liach liach added the refactor A PR that renames existing names. label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A PR that renames existing names.
Projects
None yet
Development

No branches or pull requests

2 participants