Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DrawContext.drawItemInSlot is misleading #3595

Open
Juuxel opened this issue Jun 18, 2023 · 0 comments
Open

DrawContext.drawItemInSlot is misleading #3595

Juuxel opened this issue Jun 18, 2023 · 0 comments
Labels
bug Fixes or discusses a bug within the mappings

Comments

@Juuxel
Copy link
Member

Juuxel commented Jun 18, 2023

The method does not, in fact, draw the item itself, but only the various overlays.

The corresponding 1.19 method was renderGuiItemOverlay, so a better name in 1.20.1 would probably be drawSlotItemOverlay.
@Juuxel Juuxel added the bug Fixes or discusses a bug within the mappings label Jun 18, 2023
@Juuxel Juuxel changed the title DrawContext.drawItemInSlot is confusing DrawContext.drawItemInSlot is misleading Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes or discusses a bug within the mappings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Juuxel