Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<STRUCTURE>_HAS_STRUCTURE biome tag fields should be renamed to HAS_<STRUCTURE> #3661

Open
TelepathicGrunt opened this issue Sep 10, 2023 · 2 comments
Labels
bug Fixes or discusses a bug within the mappings discussion refactor A PR that renames existing names.

Comments

@TelepathicGrunt
Copy link

TelepathicGrunt commented Sep 10, 2023

Example of what I am seeing in 1.20 Yarn BiomeTags class:
image

Personally, I feel this is a cause where it should break out of the <inner_tag>_<outer_folder> format in favor of cleaner readability.

In this case, I propose HAS_<inner_tag>. Or HAS_STRUCTURE_<inner_tag> which still reads better that current situation

@TelepathicGrunt
Copy link
Author

Another possible format is HAS_<inner_tag>_STRUCTURE just for completeness.

So

HAS_STRONGHOLD
HAS_STRONGHOLD_ STRUCTURE
HAS_STRUCTURE_STRONGHOLD

Just should ideally start with HAS_

@Juuxel
Copy link
Member

Juuxel commented Sep 10, 2023

FYI, these names are automatically generated in this format by name-proposal. The mappings for that class look pretty empty:

CLASS net/minecraft/class_6908 net/minecraft/registry/tag/BiomeTags
METHOD method_40434 of (Ljava/lang/String;)Lnet/minecraft/class_6862;
ARG 0 id

@Juuxel Juuxel added discussion refactor A PR that renames existing names. labels Sep 10, 2023
@liach liach added the bug Fixes or discusses a bug within the mappings label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes or discusses a bug within the mappings discussion refactor A PR that renames existing names.
Projects
None yet
Development

No branches or pull requests

3 participants